Re: [pgAdmin4][Patch]: Load/Save file in query tool

On Sat, May 14, 2016 at 3:37 PM, Surinder Kumar <
surinder(dot)kumar(at)enterprisedb(dot)com> wrote:

>
>
> On Sat, May 14, 2016 at 3:33 PM, Ashesh Vashi <
> ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:
>
>> On Sat, May 14, 2016 at 10:59 AM, Akshay Joshi <
>> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>>
>>> Hi Surinder
>>>
>>> On 13-May-2016 7:12 pm, "Surinder Kumar" <
>>> surinder(dot)kumar(at)enterprisedb(dot)com> wrote:
>>> >
>>> > Hi,
>>> >
>>> > Please find updated patch
>>> >
>>> > Following are the review comments given by Akshay:
>>> > 1. Save button shouldn't enable when data grid is loaded.
>>> > 2. CodeMirror text area change event should only be enabled when query
>>> tool is loaded.
>>>
>>> I have tested the patch it is not working with Chrome Browser version
>>> 48.0 gives error "unexpected token =". I have check error comes in
>>> file_manager.js line number 177. It is working fine with Firefox. Please
>>> check and send the patch again.
>>>
>> I've resolved those issues in file-manager.
>> And, reviewed the patch, which looked good to me.
>>
>> Thanks - Committed with the file-manager changes, and few tweaks.
>>
>> Surinder,
>>
>> It does not work well, whenever we select file other than SQL/text file,
>> it results into an unexpected error at server side.
>> Can you please take a look at it?
>>
> Ok.
>
FYI - I opened a dump file.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company
<http://www.enterprisedb.com/>

*http://www.linkedin.com/in/asheshvashi*
<http://www.linkedin.com/in/asheshvashi>

>
>> --
>>
>> Thanks & Regards,
>>
>> Ashesh Vashi
>> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>> <http://www.enterprisedb.com/>
>>
>>
>> *http://www.linkedin.com/in/asheshvashi*
>> <http://www.linkedin.com/in/asheshvashi>
>>
>>> >
>>> >
>>> > On Thu, May 12, 2016 at 1:23 AM, Surinder Kumar <
>>> surinder(dot)kumar(at)enterprisedb(dot)com> wrote:
>>> >>
>>> >> Hi,
>>> >>
>>> >> Please find attached patch for load/save file in query tool.
>>> >> This patch is dependent on FileManager patch.
>>> >>
>>> >> Do review the patch and let me know for any comments.
>>> >>
>>> >> Thanks,
>>> >> Surinder Kumar
>>> >
>>> >
>>> >
>>> >
>>> > --
>>> > Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
>>> > To make changes to your subscription:
>>> > http://www.postgresql.org/mailpref/pgadmin-hackers
>>> >
>>>
>>
>>
>