[pgAdmin4][patch]: Unable to create extension "postgis_topology" and "postgis_tiger_geocoder" installed through stack builder

From: Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com>
To: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: [pgAdmin4][patch]: Unable to create extension "postgis_topology" and "postgis_tiger_geocoder" installed through stack builder
Date: 2016-05-06 11:02:22
Message-ID: CAM5-9D88Ak8v-9kMiTzwmUgv4-=VK35vxrwPkf8t9rPkBv5KkQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi,

PFA patch to fix the issue:
Unable to create extension "postgis_topology" and "postgis_tiger_geocoder",
due to wrong schema name in generated SQL query.

*For example*:

It generates following query for '*postgis_toplology*' extension:
CREATE EXTENSION *postgis_topology* SCHEMA *topology*;

which is wrong. the correct query should be:
CREATE EXTENSION *postgis_topology*;

where it fetches '*topology*' schema from table *pg_available_extensions*
and
then sets schema when extension name is selected, but it should not set
schema on name change.
It is now fixed in this patch.
Thanks Fahar for reporting.

Please review and let me know for comments.

Thanks,
Surinder Kumar

Attachment Content-Type Size
unable_to_create_ext_with_postgis.patch application/octet-stream 2.3 KB

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Akshay Joshi 2016-05-06 11:58:56 Re: New committer: Akshay Joshi
Previous Message Khushboo Vashi 2016-05-06 10:39:34 [pgAdmin4][Patch]: TODO File