| From: | Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com> |
|---|---|
| To: | Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com> |
| Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>, Sarah McAlear <smcalear(at)pivotal(dot)io>, Violet Cheng <vcheng(at)pivotal(dot)io> |
| Subject: | Re: [pgAdmin4][patch] extract generate_url function from node.js and collection.js |
| Date: | 2017-08-17 16:13:49 |
| Message-ID: | CAG7mmowQ65_ptRgWWD0cdkiE_+er-Hro2xtFcxenXDYQhY3Lfw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
On Wed, Aug 16, 2017 at 4:20 PM, Khushboo Vashi <
khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
> Hi,
>
> The patch looks good to me.
>
>> Thanks,
> Khushboo
>
> On Fri, Aug 11, 2017 at 12:08 PM, Ashesh Vashi <
> ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:
>
>> On Thu, Aug 10, 2017 at 1:15 PM, Violet Cheng <vcheng(at)pivotal(dot)io> wrote:
>>
>>> Hi hackers,
>>>
>>> We tried to extract and refactor generate_url function in node.js and
>>> collection.js. Please see the patch attached.
>>>
>> Thanks - committed!
--
Thanks & Regards,
Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company
<http://www.enterprisedb.com/>
*http://www.linkedin.com/in/asheshvashi*
<http://www.linkedin.com/in/asheshvashi>
> Khushboo,
>>
>> Please review this one.
>>
>
>> --
>>
>> Thanks & Regards,
>>
>> Ashesh Vashi
>> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>> <http://www.enterprisedb.com/>
>>
>>
>> *http://www.linkedin.com/in/asheshvashi*
>> <http://www.linkedin.com/in/asheshvashi>
>>
>>>
>>> Thanks,
>>> Violet & Sarah
>>>
>>
>>
>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | pgAdmin 4 Jenkins | 2017-08-17 16:55:14 | Build failed in Jenkins: pgadmin4-master-python33 #285 |
| Previous Message | Ashesh Vashi | 2017-08-17 16:13:22 | pgAdmin 4 commit: Extract the generate_url(..) function from node.js, a |