Re: [pgAdmin4][patch] extract generate_url function from node.js and collection.js

Great! Thanks a lot.

Violet

On Fri, Aug 18, 2017 at 12:13 AM, Ashesh Vashi <
ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:

> On Wed, Aug 16, 2017 at 4:20 PM, Khushboo Vashi <
> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>
>> Hi,
>>
>> The patch looks good to me.
>>
>>> Thanks,
>> Khushboo
>>
>> On Fri, Aug 11, 2017 at 12:08 PM, Ashesh Vashi <
>> ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:
>>
>>> On Thu, Aug 10, 2017 at 1:15 PM, Violet Cheng <vcheng(at)pivotal(dot)io> wrote:
>>>
>>>> Hi hackers,
>>>>
>>>> We tried to extract and refactor generate_url function in node.js and
>>>> collection.js. Please see the patch attached.
>>>>
>>> Thanks - committed!
>
>
> --
>
> Thanks & Regards,
>
> Ashesh Vashi
> EnterpriseDB INDIA: Enterprise PostgreSQL Company
> <http://www.enterprisedb.com/>
>
>
> *http://www.linkedin.com/in/asheshvashi*
> <http://www.linkedin.com/in/asheshvashi>
>
>> Khushboo,
>>>
>>> Please review this one.
>>>
>>
>>> --
>>>
>>> Thanks & Regards,
>>>
>>> Ashesh Vashi
>>> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>>> <http://www.enterprisedb.com/>
>>>
>>>
>>> *http://www.linkedin.com/in/asheshvashi*
>>> <http://www.linkedin.com/in/asheshvashi>
>>>
>>>>
>>>> Thanks,
>>>> Violet & Sarah
>>>>
>>>
>>>
>>
>