| From: | Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com> |
|---|---|
| To: | Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com> |
| Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>, Sarah McAlear <smcalear(at)pivotal(dot)io>, Violet Cheng <vcheng(at)pivotal(dot)io> |
| Subject: | Re: [pgAdmin4][patch] extract generate_url function from node.js and collection.js |
| Date: | 2017-08-16 10:50:36 |
| Message-ID: | CAFOhELeUzvGS_pz897H8zOHj69Mk+jK+gSrrXjRqWnefBdJeVg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hi,
The patch looks good to me.
> Thanks,
Khushboo
On Fri, Aug 11, 2017 at 12:08 PM, Ashesh Vashi <
ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:
> On Thu, Aug 10, 2017 at 1:15 PM, Violet Cheng <vcheng(at)pivotal(dot)io> wrote:
>
>> Hi hackers,
>>
>> We tried to extract and refactor generate_url function in node.js and
>> collection.js. Please see the patch attached.
>>
> Khushboo,
>
> Please review this one.
>
> --
>
> Thanks & Regards,
>
> Ashesh Vashi
> EnterpriseDB INDIA: Enterprise PostgreSQL Company
> <http://www.enterprisedb.com/>
>
>
> *http://www.linkedin.com/in/asheshvashi*
> <http://www.linkedin.com/in/asheshvashi>
>
>>
>> Thanks,
>> Violet & Sarah
>>
>
>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Surinder Kumar | 2017-08-16 12:41:37 | [pgAdmin4][Patch]: RM_ 2582 - Backup : Fix compression value |
| Previous Message | Surinder Kumar | 2017-08-16 10:13:31 | Re: [pgAdmin4][Patch]: RM_2596 - Query tool not working in Desktop Runtime on Mac OS X |