Re: [Patch] Fix Unicode in errmsg

Hi Magun,

Please find my comments inline..

On Fri, Jul 8, 2016 at 9:37 PM, Magnun Leno (Pessoal) <magnun(dot)leno(at)gmail(dot)com
> wrote:

> Just found another decoding error, this time during server group creation.
>
What error are you getting?
Can you please share the exact error message to understand the issue
properly?

We will need to change too many places by this logic.
I've attached patch for it.

Path attached.
>
Thanks.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company
<http://www.enterprisedb.com/>

*http://www.linkedin.com/in/asheshvashi*
<http://www.linkedin.com/in/asheshvashi>

> Thanks again.
>
> ---
>
> Magnun Leno
>
> Em 07-07-2016 08:39, Ashesh Vashi escreveu:
>
> Sure - I will do.
>
> --
>
> Thanks & Regards,
>
> Ashesh Vashi
> EnterpriseDB INDIA: Enterprise PostgreSQL Company
> <http://www.enterprisedb.com>
>
>
> *http://www.linkedin.com/in/asheshvashi*
> <http://www.linkedin.com/in/asheshvashi>
>
> On Thu, Jul 7, 2016 at 2:31 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>> Thanks Magnun.
>>
>> Ashesh, can you review this please, and check if similar changes are
>> needed elsewhere?
>>
>> Thanks.
>>
>> On Wed, Jul 6, 2016 at 7:55 PM, Magnun Leno (Pessoal)
>> <magnun(dot)leno(at)gmail(dot)com> wrote:
>> > Hi All,
>> >
>> > Just a small patch to fix server addition/connection errors when using
>> > non-ascii languages (pt_BR in my case). I haven't delved enough into the
>> > codebase to be sure, but there might be more occurrences of errmsg that
>> need
>> > decoding from ASCII to UTF-8.
>> >
>> > Is there any plans to port PgAdmin4 to Python3, since Python 2 will
>> only be
>> > maintained until 2020? Python 3 support was added in Flask 0.10 and, as
>> > mentioned in the Flask Docs, "Most libraries and Flask extensions have
>> been
>> > ported by now and using Flask with Python 3 is generally a smooth
>> ride.".
>> >
>> > Thanks for this amazing piece of software.
>> >
>> > --
>> > Magnun Leno
>> >
>> >
>> > --
>> > Sent via pgadmin-hackers mailing list (
>> <pgadmin-hackers(at)postgresql(dot)org>pgadmin-hackers(at)postgresql(dot)org)
>> > To make changes to your subscription:
>> > http://www.postgresql.org/mailpref/pgadmin-hackers
>> >
>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>