Re: [Patch] Fix Unicode in errmsg

From: "Magnun Leno (Pessoal)" <magnun(dot)leno(at)gmail(dot)com>
To: pgadmin-hackers(at)postgresql(dot)org
Subject: Re: [Patch] Fix Unicode in errmsg
Date: 2016-07-08 16:07:40
Message-ID: d9ddf1d3-8a88-d5a0-40cc-da2b46596513@gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Just found another decoding error, this time during server group
creation. Path attached.

Thanks again.

---

Magnun Leno

Em 07-07-2016 08:39, Ashesh Vashi escreveu:
> Sure - I will do.
>
> --
>
> Thanks & Regards,
>
> Ashesh Vashi
> EnterpriseDB INDIA: Enterprise PostgreSQL Company
> <http://www.enterprisedb.com>
>
>
> /http://www.linkedin.com/in/asheshvashi/
>
>
> On Thu, Jul 7, 2016 at 2:31 PM, Dave Page <dpage(at)pgadmin(dot)org
> <mailto:dpage(at)pgadmin(dot)org>> wrote:
>
> Thanks Magnun.
>
> Ashesh, can you review this please, and check if similar changes are
> needed elsewhere?
>
> Thanks.
>
> On Wed, Jul 6, 2016 at 7:55 PM, Magnun Leno (Pessoal)
> <magnun(dot)leno(at)gmail(dot)com <mailto:magnun(dot)leno(at)gmail(dot)com>> wrote:
> > Hi All,
> >
> > Just a small patch to fix server addition/connection errors when
> using
> > non-ascii languages (pt_BR in my case). I haven't delved enough
> into the
> > codebase to be sure, but there might be more occurrences of
> errmsg that need
> > decoding from ASCII to UTF-8.
> >
> > Is there any plans to port PgAdmin4 to Python3, since Python 2
> will only be
> > maintained until 2020? Python 3 support was added in Flask 0.10
> and, as
> > mentioned in the Flask Docs, "Most libraries and Flask
> extensions have been
> > ported by now and using Flask with Python 3 is generally a
> smooth ride.".
> >
> > Thanks for this amazing piece of software.
> >
> > --
> > Magnun Leno
> >
> >
> > --
> > Sent via pgadmin-hackers mailing list
> (pgadmin-hackers(at)postgresql(dot)org
> <mailto:pgadmin-hackers(at)postgresql(dot)org>)
> > To make changes to your subscription:
> > http://www.postgresql.org/mailpref/pgadmin-hackers
> >
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>

Attachment Content-Type Size
fix_unicode_servername_input.patch.tar.bz2 application/x-bzip 775 bytes

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Murtuza Zabuawala 2016-07-11 07:11:56 PATCH: To fix salt generation in session.py
Previous Message Stuart Gathman 2016-07-08 14:45:51 [pgadmin3][Patch] Null this in pgConn::GetStatus