Re: JavaScript Errors in the Query Tool Leads to a False Message

From: Avin Kavish <avinkavish(at)gmail(dot)com>
To: Yosry Muhammad <yosrym93(at)gmail(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>, Dave Page <dpage(at)pgadmin(dot)org>
Subject: Re: JavaScript Errors in the Query Tool Leads to a False Message
Date: 2019-08-06 04:36:10
Message-ID: CAFpscOTn5LonUewamkRiKZw+ZjbeoxnDc4H-QCYGbRasuKuoUg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Is there a way to reproduce this? i.e force a js error during query
execution? One reason I can think of is using $.ajax({ async: false }) so
the ajax request gets handled on the main thread and anything that throws
on to the main thread gets caught.

On Tue, Aug 6, 2019 at 4:07 AM Yosry Muhammad <yosrym93(at)gmail(dot)com> wrote:

> Hi Hackers,
>
> I have noticed a strange behavior in the JS code of the Query Tool. When a
> JS error occurs at any point during the execution of a query, the code is
> traced back to the last ajax call and goes to the catch portion (as if the
> ajax call failed). This leads to a "Not connected to the server" error
> message to the user, which is wrong.
>
> I noticed this behavior before when fixing the bug where "Not connected to
> the server" message appeared when the user queries a column with no
> columns, which was due to a JS error being mistakenly identified as an ajax
> error.
>
> Does anybody have any idea why this happens? This doesn't seem right.
>
> Thanks.
> *Yosry Muhammad Yosry*
>
> Computer Engineering student,
> The Faculty of Engineering,
> Cairo University (2021).
> Class representative of CMP 2021.
> https://www.linkedin.com/in/yosrym93/
>

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Aditya Toshniwal 2019-08-06 04:41:39 Re: JavaScript Errors in the Query Tool Leads to a False Message
Previous Message Avin Kavish 2019-08-06 04:11:46 Re: Query Tool Slow to Load