JavaScript Errors in the Query Tool Leads to a False Message

From: Yosry Muhammad <yosrym93(at)gmail(dot)com>
To: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>, Dave Page <dpage(at)pgadmin(dot)org>
Subject: JavaScript Errors in the Query Tool Leads to a False Message
Date: 2019-08-05 22:37:25
Message-ID: CAFSMqn9DzqiERfw=_q=keq1rEdCJBnThjKjYXU4T4Ce_r03xrA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Hackers,

I have noticed a strange behavior in the JS code of the Query Tool. When a
JS error occurs at any point during the execution of a query, the code is
traced back to the last ajax call and goes to the catch portion (as if the
ajax call failed). This leads to a "Not connected to the server" error
message to the user, which is wrong.

I noticed this behavior before when fixing the bug where "Not connected to
the server" message appeared when the user queries a column with no
columns, which was due to a JS error being mistakenly identified as an ajax
error.

Does anybody have any idea why this happens? This doesn't seem right.

Thanks.
*Yosry Muhammad Yosry*

Computer Engineering student,
The Faculty of Engineering,
Cairo University (2021).
Class representative of CMP 2021.
https://www.linkedin.com/in/yosrym93/

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Yosry Muhammad 2019-08-06 00:16:08 [GSoC] Query History Integration with updatable query resultsets and improvements
Previous Message Dave Page 2019-08-05 13:42:01 Re: Query Tool Slow to Load