Re: JavaScript Errors in the Query Tool Leads to a False Message

From: Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com>
To: Avin Kavish <avinkavish(at)gmail(dot)com>
Cc: Yosry Muhammad <yosrym93(at)gmail(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>, Dave Page <dpage(at)pgadmin(dot)org>
Subject: Re: JavaScript Errors in the Query Tool Leads to a False Message
Date: 2019-08-06 04:41:39
Message-ID: CAM9w-_kNk8a4Ns2yFN4gZc--oV402sQ+-cqCfdZyk6OY470pHQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Yosry,

Yes, I have experienced the same but missed to log a bug. You can log a bug
so that someone can work on it.
To simulate the issue, just add some JS code that will cause error.

On Tue, Aug 6, 2019 at 10:06 AM Avin Kavish <avinkavish(at)gmail(dot)com> wrote:

> Is there a way to reproduce this? i.e force a js error during query
> execution? One reason I can think of is using $.ajax({ async: false }) so
> the ajax request gets handled on the main thread and anything that throws
> on to the main thread gets caught.
>
> On Tue, Aug 6, 2019 at 4:07 AM Yosry Muhammad <yosrym93(at)gmail(dot)com> wrote:
>
>> Hi Hackers,
>>
>> I have noticed a strange behavior in the JS code of the Query Tool. When
>> a JS error occurs at any point during the execution of a query, the code is
>> traced back to the last ajax call and goes to the catch portion (as if the
>> ajax call failed). This leads to a "Not connected to the server" error
>> message to the user, which is wrong.
>>
>> I noticed this behavior before when fixing the bug where "Not connected
>> to the server" message appeared when the user queries a column with no
>> columns, which was due to a JS error being mistakenly identified as an ajax
>> error.
>>
>> Does anybody have any idea why this happens? This doesn't seem right.
>>
>> Thanks.
>> *Yosry Muhammad Yosry*
>>
>> Computer Engineering student,
>> The Faculty of Engineering,
>> Cairo University (2021).
>> Class representative of CMP 2021.
>> https://www.linkedin.com/in/yosrym93/
>>
>

--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Yosry Muhammad 2019-08-06 04:41:59 Re: JavaScript Errors in the Query Tool Leads to a False Message
Previous Message Avin Kavish 2019-08-06 04:36:10 Re: JavaScript Errors in the Query Tool Leads to a False Message