| From: | Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com> |
|---|---|
| To: | Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, Rushabh Lathia <rushabh(dot)lathia(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Postgres_fdw join pushdown - wrong results with whole-row reference |
| Date: | 2016-06-28 06:23:07 |
| Message-ID: | CAFjFpRcMVWZfEYO+45OKFxDDbP_WFzPoLMvCU9QNMVMW_fEfHg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jun 28, 2016 at 11:43 AM, Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp
> wrote:
> On 2016/06/28 13:53, Ashutosh Bapat wrote:
>
>> Ideally, we should point out the specific column that faced the
>> conversion problem and report it, instead of saying the whole row
>> reference conversion caused the problem. But that may be too difficult.
>>
>
> I think so too.
>
> Or at least the error message should read "whole row reference of
>> foreign table ft1".
>>
>
> OK, attached is an updated version of the patch, which uses "whole-row
> reference", not "wholerow".
>
The wording "column "whole-row reference ..." doesn't look good. Whole-row
reference is not a column. The error context itself should be "whole row
reference for foreign table ft1".
--
Best Wishes,
Ashutosh Bapat
EnterpriseDB Corporation
The Postgres Database Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Noah Misch | 2016-06-28 06:32:52 | Re: Should phraseto_tsquery('simple', 'blue blue') @@ to_tsvector('simple', 'blue') be true ? |
| Previous Message | Etsuro Fujita | 2016-06-28 06:13:17 | Re: Postgres_fdw join pushdown - wrong results with whole-row reference |