Re: Postgres_fdw join pushdown - wrong results with whole-row reference

From: Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp>
To: Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, Rushabh Lathia <rushabh(dot)lathia(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Postgres_fdw join pushdown - wrong results with whole-row reference
Date: 2016-06-28 07:22:28
Message-ID: d5761b2c-8fa1-297d-1a76-3a3621d98b2b@lab.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2016/06/28 15:23, Ashutosh Bapat wrote:
> The wording "column "whole-row reference ..." doesn't look good.
> Whole-row reference is not a column. The error context itself should be
> "whole row reference for foreign table ft1".

Ah, you are right. Please find attached an updated version.

Best regards,
Etsuro Fujita

Attachment Content-Type Size
postgres-fdw-conv-error-callback-v4.patch binary/octet-stream 2.5 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Gilles Darold 2016-06-28 09:06:24 Re: Patch to implement pg_current_logfile() function
Previous Message Noah Misch 2016-06-28 06:32:52 Re: Should phraseto_tsquery('simple', 'blue blue') @@ to_tsvector('simple', 'blue') be true ?