Re: Postgres_fdw join pushdown - wrong results with whole-row reference

From: Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp>
To: Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, Rushabh Lathia <rushabh(dot)lathia(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Postgres_fdw join pushdown - wrong results with whole-row reference
Date: 2016-06-28 06:13:17
Message-ID: 4486e69f-5c8d-9d9e-db70-117e2a0fafec@lab.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2016/06/28 13:53, Ashutosh Bapat wrote:
> Ideally, we should point out the specific column that faced the
> conversion problem and report it, instead of saying the whole row
> reference conversion caused the problem. But that may be too difficult.

I think so too.

> Or at least the error message should read "whole row reference of
> foreign table ft1".

OK, attached is an updated version of the patch, which uses "whole-row
reference", not "wholerow".

Best regards,
Etsuro Fujita

Attachment Content-Type Size
postgres-fdw-conv-error-callback-v3.patch binary/octet-stream 2.0 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Ashutosh Bapat 2016-06-28 06:23:07 Re: Postgres_fdw join pushdown - wrong results with whole-row reference
Previous Message Rushabh Lathia 2016-06-28 05:52:20 ERROR: ORDER/GROUP BY expression not found in targetlist