From: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
---|---|
To: | Andres Freund <andres(at)anarazel(dot)de> |
Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: pgsql: Default to hidden visibility for extension libraries where possi |
Date: | 2022-07-19 15:37:11 |
Message-ID: | CAFj8pRAFxc3-SHMD3URU09JZXEKY3W-RwXKp8xPEnEq8rrka7w@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
Hi
út 19. 7. 2022 v 17:31 odesílatel Andres Freund <andres(at)anarazel(dot)de> napsal:
> Hi,
>
> On 2022-07-19 16:28:07 +0200, Alvaro Herrera wrote:
> > Anyway, the minimal patch that makes plpgsql_check tests pass is
> > attached. This seems a bit random. Maybe it'd be better to have a
> > plpgsql_internal.h with functions that are exported only for plpgsql
> > itself, and keep plpgsql.h with a set of functions, all marked
> > PGDLLEXPORT, that are for external use.
>
> It does seem a bit random. But I think we probably should err on the side
> of
> adding more declarations, rather than the oposite.
>
This list can be extended. I think plpgsql_check is maybe one extension
that uses code from another extension directly. This is really not common
usage.
>
> I like the plpgsql_internal.h idea, but probably done separately?
>
can be
I have not any problem with it or with exports.txt file.
> Greetings,
>
> Andres Freund
>
From | Date | Subject | |
---|---|---|---|
Next Message | Andres Freund | 2022-07-19 15:40:04 | Re: pgsql: Default to hidden visibility for extension libraries where possi |
Previous Message | Andres Freund | 2022-07-19 15:31:49 | Re: pgsql: Default to hidden visibility for extension libraries where possi |
From | Date | Subject | |
---|---|---|---|
Next Message | Andres Freund | 2022-07-19 15:40:04 | Re: pgsql: Default to hidden visibility for extension libraries where possi |
Previous Message | Andres Freund | 2022-07-19 15:37:03 | Re: PG 15 (and to a smaller degree 14) regression due to ExprEvalStep size |