From: | Andres Freund <andres(at)anarazel(dot)de> |
---|---|
To: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: pgsql: Default to hidden visibility for extension libraries where possi |
Date: | 2022-07-19 15:40:04 |
Message-ID: | 20220719154004.q56qzla6hmxcvh7u@awork3.anarazel.de |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
Hi,
On 2022-07-19 17:37:11 +0200, Pavel Stehule wrote:
> út 19. 7. 2022 v 17:31 odesílatel Andres Freund <andres(at)anarazel(dot)de> napsal:
>
> > Hi,
> >
> > On 2022-07-19 16:28:07 +0200, Alvaro Herrera wrote:
> > > Anyway, the minimal patch that makes plpgsql_check tests pass is
> > > attached. This seems a bit random. Maybe it'd be better to have a
> > > plpgsql_internal.h with functions that are exported only for plpgsql
> > > itself, and keep plpgsql.h with a set of functions, all marked
> > > PGDLLEXPORT, that are for external use.
> >
> > It does seem a bit random. But I think we probably should err on the side
> > of
> > adding more declarations, rather than the oposite.
> >
>
> This list can be extended. I think plpgsql_check is maybe one extension
> that uses code from another extension directly. This is really not common
> usage.
There's a few more use cases, e.g. transform modules. Hence exposing e.g. many
plpython helpers.
> I have not any problem with it or with exports.txt file.
Just to be clear, there shouldn't be any use exports.txt here, just a few
PGDLLEXPORTs.
Greetings,
Andres Freund
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2022-07-19 16:29:45 | pgsql: Convert planner's AggInfo and AggTransInfo structs to proper Nod |
Previous Message | Pavel Stehule | 2022-07-19 15:37:11 | Re: pgsql: Default to hidden visibility for extension libraries where possi |
From | Date | Subject | |
---|---|---|---|
Next Message | Rafael Thofehrn Castro | 2022-07-19 15:40:06 | Autovacuum worker spawning strategy |
Previous Message | Pavel Stehule | 2022-07-19 15:37:11 | Re: pgsql: Default to hidden visibility for extension libraries where possi |