Re: pgsql: Default to hidden visibility for extension libraries where possi

From: Andres Freund <andres(at)anarazel(dot)de>
To: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Default to hidden visibility for extension libraries where possi
Date: 2022-07-19 15:31:49
Message-ID: 20220719153149.lhbir3wh4sgfkfe7@awork3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Hi,

On 2022-07-19 16:28:07 +0200, Alvaro Herrera wrote:
> Anyway, the minimal patch that makes plpgsql_check tests pass is
> attached. This seems a bit random. Maybe it'd be better to have a
> plpgsql_internal.h with functions that are exported only for plpgsql
> itself, and keep plpgsql.h with a set of functions, all marked
> PGDLLEXPORT, that are for external use.

It does seem a bit random. But I think we probably should err on the side of
adding more declarations, rather than the oposite.

I like the plpgsql_internal.h idea, but probably done separately?

Greetings,

Andres Freund

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Pavel Stehule 2022-07-19 15:37:11 Re: pgsql: Default to hidden visibility for extension libraries where possi
Previous Message Tom Lane 2022-07-19 15:18:28 pgsql: Estimate cost of elided SubqueryScan, Append, MergeAppend nodes

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2022-07-19 15:37:03 Re: PG 15 (and to a smaller degree 14) regression due to ExprEvalStep size
Previous Message Tom Lane 2022-07-19 15:19:39 Re: Costing elided SubqueryScans more nearly correctly