| From: | Matheus Alcantara <matheusssilv97(at)gmail(dot)com> |
|---|---|
| To: | jian he <jian(dot)universality(at)gmail(dot)com> |
| Cc: | Kirill Reshke <reshkekirill(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: read stream on amcheck |
| Date: | 2025-02-11 18:41:31 |
| Message-ID: | CAFY6G8dNXFvg7BUx6RF3+6+riiN-HoBd9DN3qdU=tMiO875Wzg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
Em ter., 11 de fev. de 2025 às 03:39, jian he
<jian(dot)universality(at)gmail(dot)com> escreveu:
> hi. some minor issue i found.
>
> +#include "storage/block.h"
> no need, since "#include "storage/bufmgr.h" already included it.
>
Fixed
> do we need to add ``CHECK_FOR_INTERRUPTS()`` in heapam_read_stream_next_block?
>
The current code on master don't CHECK_FOR_INTERRUPTS, so I would prefer to not
change this behaviour, but I think that is considerable.
> heapam_read_stream_next_block_private need add to
> src/tools/pgindent/typedefs.list
>
Fixed
> overall, it looks good to me.
Thanks for the review! v3 with the fixes attached.
--
Matheus Alcantara
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-Use-read-stream-on-amcheck.patch | application/octet-stream | 4.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Álvaro Herrera | 2025-02-11 18:51:43 | Re: pg_stat_statements and "IN" conditions |
| Previous Message | James Hunter | 2025-02-11 18:39:51 | Re: Proposal: "query_work_mem" GUC, to distribute working memory to the query's individual operators |