Re: read stream on amcheck

From: jian he <jian(dot)universality(at)gmail(dot)com>
To: Matheus Alcantara <matheusssilv97(at)gmail(dot)com>
Cc: Kirill Reshke <reshkekirill(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: read stream on amcheck
Date: 2025-02-11 06:39:12
Message-ID: CACJufxH8eK_yEk3Sn=W+zfvQEp8sCDWfwqcsLd8A7GiEhZF7NQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Jan 3, 2025 at 1:53 AM Matheus Alcantara
<matheusssilv97(at)gmail(dot)com> wrote:
>
>
> Yeap, I agree. Attached a v2 fixed.
>

hi. some minor issue i found.

+#include "storage/block.h"
no need, since "#include "storage/bufmgr.h" already included it.

do we need to add ``CHECK_FOR_INTERRUPTS()`` in heapam_read_stream_next_block?

heapam_read_stream_next_block_private need add to
src/tools/pgindent/typedefs.list

overall, it looks good to me.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Ashutosh Bapat 2025-02-11 06:49:33 Re: Test to dump and restore objects left behind by regression
Previous Message Amit Kapila 2025-02-11 06:17:34 Re: Introduce XID age and inactive timeout based replication slot invalidation