Re: read stream on amcheck

From: vignesh C <vignesh21(at)gmail(dot)com>
To: Matheus Alcantara <matheusssilv97(at)gmail(dot)com>
Cc: jian he <jian(dot)universality(at)gmail(dot)com>, Kirill Reshke <reshkekirill(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: read stream on amcheck
Date: 2025-03-16 13:30:17
Message-ID: CALDaNm15c9u0ziv1c-UG74r_gV=GRLBwKYCu3SOkdLEX70y9VQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, 12 Feb 2025 at 00:11, Matheus Alcantara
<matheusssilv97(at)gmail(dot)com> wrote:
>
> Hi,
>
> Em ter., 11 de fev. de 2025 às 03:39, jian he
> <jian(dot)universality(at)gmail(dot)com> escreveu:
> > hi. some minor issue i found.
> >
> > +#include "storage/block.h"
> > no need, since "#include "storage/bufmgr.h" already included it.
> >
> Fixed
>
> > do we need to add ``CHECK_FOR_INTERRUPTS()`` in heapam_read_stream_next_block?
> >
> The current code on master don't CHECK_FOR_INTERRUPTS, so I would prefer to not
> change this behaviour, but I think that is considerable.
>
> > heapam_read_stream_next_block_private need add to
> > src/tools/pgindent/typedefs.list
> >
> Fixed
>
> > overall, it looks good to me.
>
> Thanks for the review! v3 with the fixes attached.

I noticed that Nazir Bilal Yavuz's comment from [1] is not yet
addressed, i have changed the status of commitfest entry to Waiting on
Author, please address them and update it to Needs review.
[1] - https://www.postgresql.org/message-id/CAN55FZ2CGxcqTk_LLRPAi2aFNqtR4o=JPfjN0=yT0yObfQ2h2g@mail.gmail.com

Regards,
Vignesh

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message vignesh C 2025-03-16 13:32:11 Re: Implement waiting for wal lsn replay: reloaded
Previous Message vignesh C 2025-03-16 13:19:47 Re: Doc: Move standalone backup section, mention -X argument