Re: [pgAdmin4][Patch] - RM 3664 - Statistic panel hangs when 1000+ tables

From: Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com>
To: Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com>
Cc: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][Patch] - RM 3664 - Statistic panel hangs when 1000+ tables
Date: 2019-01-29 09:47:05
Message-ID: CAFOhELfq7sHRHF+7-+B-1DOmNHowD8519tMLcbLTdG0FL24j1w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi,

Please find the attached updated patch.
I have also improved the performance of the properties tab.
Please also apply the bootstrap toggle patch to check the properties tab
performance.

Thanks,
Khushboo

On Tue, Jan 22, 2019 at 5:05 PM Aditya Toshniwal <
aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:

> Hi Khushboo,
>
> There is improvement than before but the UI still lags. I tested with 2000
> tables and statistics on Tables node.
> I would also suggest to add further rows only if scrolling down. Rows
> adding can be avoided even if the scroll does not take to the last element.
> Currently, if I scroll slightly down it add rows and if I scroll back up
> it adds more. I think the scroll up fetch can be avoided.
>
> On Mon, Jan 21, 2019 at 4:43 PM Akshay Joshi <
> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>
>> Hi Aditya
>>
>> Can you please review it.
>>
>> On Thu, Jan 17, 2019 at 11:36 AM Khushboo Vashi <
>> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>>
>>> Hi,
>>>
>>> Please find the attached patch to fix the RM 3664 - Statistic panel
>>> hangs when 1000+ tables
>>>
>>> The statistics tab hangs with more rows. So, now the rows will be pushed
>>> in the backgrid collection in bunches on scroll event to fix this issue.
>>>
>>> Thanks,
>>> Khushboo
>>>
>>
>>
>> --
>> *Akshay Joshi*
>>
>> *Sr. Software Architect *
>>
>>
>>
>> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>>
>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Software Engineer | EnterpriseDB Software Solutions | Pune
> "Don't Complain about Heat, Plant a tree"
>

Attachment Content-Type Size
RM_3664_v1.patch application/octet-stream 3.0 KB

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2019-01-29 11:18:42 Re: [pgAdmin4][Patch]: RM 3927 Unable to debug the procedure inside package
Previous Message Akshay Joshi 2019-01-29 09:35:05 [pgAdmin4][Patch]: RM 3697 Detached Data Output Tab (Windows) does not show Select output