Re: [pgAdmin4][Patch] - RM 3664 - Statistic panel hangs when 1000+ tables

Hi Khushboo,

The patch looks good to me and statistics works great now. Tested with 2000
tables.
However, I did not get what did the below change do.

*diff --git a/web/pgadmin/misc/statistics/static/js/statistics.js
b/web/pgadmin/misc/statistics/static/js/statistics.js*

*index cfd573e1..5441f883 100644*

*--- a/web/pgadmin/misc/statistics/static/js/statistics.js*

*+++ b/web/pgadmin/misc/statistics/static/js/statistics.js*

@@ -104,7 +104,9 @@ define('misc.statistics', [

offText: gettext('False'),

onColor: 'success',

offColor: 'primary',

- size: 'mini',

+ size: 'small',

+ width: null,

+ height: null,

}

);

@Committer,

Except above change, all looks good to me.

On Tue, Jan 29, 2019 at 3:17 PM Khushboo Vashi <
khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:

> Hi,
>
> Please find the attached updated patch.
> I have also improved the performance of the properties tab.
> Please also apply the bootstrap toggle patch to check the properties tab
> performance.
>
> Thanks,
> Khushboo
>
> On Tue, Jan 22, 2019 at 5:05 PM Aditya Toshniwal <
> aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
>
>> Hi Khushboo,
>>
>> There is improvement than before but the UI still lags. I tested with
>> 2000 tables and statistics on Tables node.
>> I would also suggest to add further rows only if scrolling down. Rows
>> adding can be avoided even if the scroll does not take to the last element.
>> Currently, if I scroll slightly down it add rows and if I scroll back up
>> it adds more. I think the scroll up fetch can be avoided.
>>
>> On Mon, Jan 21, 2019 at 4:43 PM Akshay Joshi <
>> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>>
>>> Hi Aditya
>>>
>>> Can you please review it.
>>>
>>> On Thu, Jan 17, 2019 at 11:36 AM Khushboo Vashi <
>>> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>>>
>>>> Hi,
>>>>
>>>> Please find the attached patch to fix the RM 3664 - Statistic panel
>>>> hangs when 1000+ tables
>>>>
>>>> The statistics tab hangs with more rows. So, now the rows will be
>>>> pushed in the backgrid collection in bunches on scroll event to fix this
>>>> issue.
>>>>
>>>> Thanks,
>>>> Khushboo
>>>>
>>>
>>>
>>> --
>>> *Akshay Joshi*
>>>
>>> *Sr. Software Architect *
>>>
>>>
>>>
>>> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>>>
>>
>>
>> --
>> Thanks and Regards,
>> Aditya Toshniwal
>> Software Engineer | EnterpriseDB Software Solutions | Pune
>> "Don't Complain about Heat, Plant a tree"
>>
>

--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"