| From: | Dave Page <dpage(at)pgadmin(dot)org> |
|---|---|
| To: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
| Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: [pgAdmin4][Patch]: RM 3927 Unable to debug the procedure inside package |
| Date: | 2019-01-29 11:18:42 |
| Message-ID: | CA+OCxoyxdYFWdCPcwqmeVAjhB=NdRF7aOAb0HptPRDv0FY7meA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Khushboo, can you review this please? If you're happy with it, Akshay
can commit.
Thanks.
On Mon, Jan 28, 2019 at 12:33 PM Akshay Joshi
<akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>
> Hi Hackers,
>
> Attached is the patch to fix RM 3927 "Unable to debug the procedure inside package". Problem with the existing code is we assume that "PLDBGBREAK" will be always found in the first element of the notification list.
>
> In this patch we loop through the list and found the string. Apart from that patch contains small fix to cancel the transaction of Query Tool when panel is closed.
>
> Please review it.
>
> --
> Akshay Joshi
> Sr. Software Architect
>
>
> Phone: +91 20-3058-9517
> Mobile: +91 976-788-8246
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dave Page | 2019-01-29 11:24:20 | Re: [pgAdmin4][Patch]: RM 3697 Detached Data Output Tab (Windows) does not show Select output |
| Previous Message | Khushboo Vashi | 2019-01-29 09:47:05 | Re: [pgAdmin4][Patch] - RM 3664 - Statistic panel hangs when 1000+ tables |