From: | Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com> |
---|---|
To: | Dave Page <dpage(at)pgadmin(dot)org>, Joao Pedro De Almeida Pereira <jdealmeidapereira(at)pivotal(dot)io>, vhenry(at)pivotal(dot)io |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: pgAdmin 4 commit: Refactor server dialogue validation for better unit t |
Date: | 2018-03-14 14:37:10 |
Message-ID: | CAFOhELfb1KY7zhzSOYvtn3R7FYmTXN6RcZ82NsgFNAeTXuv-hQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi Joao/Victoria,
I am getting an error while editing the server properties. Please refer the
attached screen-shot for the same.
Thanks,
Khushboo
On Wed, Mar 14, 2018 at 12:17 AM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
> Refactor server dialogue validation for better unit testing.
>
> Victoria & Joao @ Pivotal.
>
> Branch
> ------
> master
>
> Details
> -------
> https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=
> 6b03cb78af607b04c75de44d635bf201babb4c5a
> Author: Victoria Henry <vhenry(at)pivotal(dot)io>
>
> Modified Files
> --------------
> web/package.json | 3 +-
> .../server_groups/servers/static/js/server.js | 113
> ++-------------------
> web/pgadmin/static/bundle/browser.js | 2 +-
> web/pgadmin/static/js/browser/index.js | 10 ++
> .../static/js/browser/server_groups/index.js | 10 ++
> .../server_groups/servers/databases/index.js | 10 ++
> .../js/browser/server_groups/servers/index.js | 11 ++
> .../server_groups/servers/model_validation.js | 104
> +++++++++++++++++++
> .../server_groups/servers/model_validation_spec.js | 101
> ++++++++++++++++++
> web/yarn.lock | 46 ++++++++-
> 10 files changed, 299 insertions(+), 111 deletions(-)
>
>
Attachment | Content-Type | Size |
---|---|---|
Screen Shot 2018-03-14 at 8.01.46 pm.png | image/png | 474.1 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Khushboo Vashi | 2018-03-14 14:55:37 | Re: [pgadmin4][Patch]: RM #3122 - Backup not working on certificate (SSL) protected servers |
Previous Message | Khushboo Vashi | 2018-03-14 07:37:17 | Re: [pgadmin4][Patch]: RM #3122 - Backup not working on certificate (SSL) protected servers |