Re: [pgadmin4][Patch]: RM #3122 - Backup not working on certificate (SSL) protected servers

On Wed, Mar 14, 2018 at 12:48 PM, Murtuza Zabuawala <
murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:

> ../pgadmin4/web/pgadmin/tools/import_export/__init__.py +310 without
> your patch applied.
>
> Yes, good point. Will update and send the patch.

>
> On Wed, Mar 14, 2018 at 12:39 PM, Murtuza Zabuawala <murtuza.zabuawala@
> enterprisedb.com> wrote:
>
>> Hi Khushboo,
>>
>> We can simplify this, we don't need to create any extra column,
>>
>> Check: ../pgadmin4/web/pgadmin/tools/import_export/__init__.py +322
>> where we are setting ENV variable we can create common utility function
>> (let say in ../tools/utils/__init__.py) which will set all required the
>> environment variables and then we will pass that function in p.start(..)
>> method.
>>
>>
>> --
>> Regards,
>> Murtuza Zabuawala
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>>
>> On Wed, Mar 14, 2018 at 11:03 AM, Khushboo Vashi <
>> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>>
>>> Hi,
>>>
>>> Please find the attached patch to fix RM #3122 : Backup not working on
>>> certificate (SSL) protected servers.
>>>
>>> The attached patch fixes the issue in the following modules:
>>>
>>> 1. Backup
>>> 2. Restore
>>> 3. Import/Export
>>> 4. Maintenance
>>>
>>> Thanks,
>>> Khushboo
>>>
>>>
>>>
>>
>