Re: [pgadmin4][Patch]: RM #3122 - Backup not working on certificate (SSL) protected servers

From: Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com>
To: Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgadmin4][Patch]: RM #3122 - Backup not working on certificate (SSL) protected servers
Date: 2018-03-14 07:18:49
Message-ID: CAKKotZT5R4knox3zH0E5A5gMn6TZ7qSR=c2-a1Qqc8cdj7+2Gg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

../pgadmin4/web/pgadmin/tools/import_export/__init__.py +310 without your
patch applied.

On Wed, Mar 14, 2018 at 12:39 PM, Murtuza Zabuawala <
murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:

> Hi Khushboo,
>
> We can simplify this, we don't need to create any extra column,
>
> Check: ../pgadmin4/web/pgadmin/tools/import_export/__init__.py +322 where
> we are setting ENV variable we can create common utility function (let say
> in ../tools/utils/__init__.py) which will set all required the environment
> variables and then we will pass that function in p.start(..) method.
>
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> On Wed, Mar 14, 2018 at 11:03 AM, Khushboo Vashi <
> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>
>> Hi,
>>
>> Please find the attached patch to fix RM #3122 : Backup not working on
>> certificate (SSL) protected servers.
>>
>> The attached patch fixes the issue in the following modules:
>>
>> 1. Backup
>> 2. Restore
>> 3. Import/Export
>> 4. Maintenance
>>
>> Thanks,
>> Khushboo
>>
>>
>>
>

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Khushboo Vashi 2018-03-14 07:37:17 Re: [pgadmin4][Patch]: RM #3122 - Backup not working on certificate (SSL) protected servers
Previous Message Murtuza Zabuawala 2018-03-14 07:09:57 Re: [pgadmin4][Patch]: RM #3122 - Backup not working on certificate (SSL) protected servers