Re: pgAdmin 4 commit: Refactor server dialogue validation for better unit t

Hi Khushboo,
Good catch, attached you can find the fix for the problem.

Thanks
Victoria & Joao

On Wed, Mar 14, 2018 at 10:37 AM Khushboo Vashi <
khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:

> Hi Joao/Victoria,
>
> I am getting an error while editing the server properties. Please refer
> the attached screen-shot for the same.
>
> Thanks,
> Khushboo
>
> On Wed, Mar 14, 2018 at 12:17 AM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>> Refactor server dialogue validation for better unit testing.
>>
>> Victoria & Joao @ Pivotal.
>>
>> Branch
>> ------
>> master
>>
>> Details
>> -------
>>
>> https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6b03cb78af607b04c75de44d635bf201babb4c5a
>> Author: Victoria Henry <vhenry(at)pivotal(dot)io>
>>
>> Modified Files
>> --------------
>> web/package.json | 3 +-
>> .../server_groups/servers/static/js/server.js | 113
>> ++-------------------
>> web/pgadmin/static/bundle/browser.js | 2 +-
>> web/pgadmin/static/js/browser/index.js | 10 ++
>> .../static/js/browser/server_groups/index.js | 10 ++
>> .../server_groups/servers/databases/index.js | 10 ++
>> .../js/browser/server_groups/servers/index.js | 11 ++
>> .../server_groups/servers/model_validation.js | 104
>> +++++++++++++++++++
>> .../server_groups/servers/model_validation_spec.js | 101
>> ++++++++++++++++++
>> web/yarn.lock | 46 ++++++++-
>> 10 files changed, 299 insertions(+), 111 deletions(-)
>>
>>
>