Re: [GSoC] Finalized First Patch

Hi,

On Wed, Jul 10, 2019 at 3:11 PM Yosry Muhammad <yosrym93(at)gmail(dot)com> wrote:

> Hi,
>
> On Wed, Jul 10, 2019, 9:14 AM Khushboo Vashi <
> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>
>> Some points I missed:
>> 1. I assumed that in this patch modification in case of OIDs= True
>> (without primary key) has not considered as that is not working.
>>
>
> This is not implemented yet. I will work on that in a following patch soon
> enough.
>
> Okay.

> 2. As we are already showing the changed Data prompt on closing the Query
>> Tool, do we really need the Uncommitted Transaction prompt?
>>
>
> This is needed when auto-commit is off. Saving changes in the data grid is
> performed as part of the ongoing transaction (or a new one if none is
> ongoing). After saving the data changes the user should still commit the
> current transaction for the changes to be commited to the database. This
> feature is also useful in general when auto-commit is off as users may
> forget to commit ongoing transactions.
>
> One thing I have noticed, when I add a new row and delete it immediately
without saving it and try to close the query tool, the uncommitted prompt
is coming.
In my opinion, it should not come, what do you think?

We should disable the prompt if auto-commit and auto-rollback both are
enabled.

Thanks,
Khushboo

> Thanks and Regards :D
>