| From: | Yosry Muhammad <yosrym93(at)gmail(dot)com> |
|---|---|
| To: | Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com> |
| Cc: | Dave Page <dpage(at)pgadmin(dot)org>, pgadmin-hackers(at)postgresql(dot)org, Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
| Subject: | Re: [GSoC] Finalized First Patch |
| Date: | 2019-07-10 09:41:13 |
| Message-ID: | CAFSMqn_gEi1JyeHdeFqWKtjg9w4T8p7Edi8iKPEtX1_qZjo0Fg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hi,
On Wed, Jul 10, 2019, 9:14 AM Khushboo Vashi <
khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
> Some points I missed:
> 1. I assumed that in this patch modification in case of OIDs= True
> (without primary key) has not considered as that is not working.
>
This is not implemented yet. I will work on that in a following patch soon
enough.
2. As we are already showing the changed Data prompt on closing the Query
> Tool, do we really need the Uncommitted Transaction prompt?
>
This is needed when auto-commit is off. Saving changes in the data grid is
performed as part of the ongoing transaction (or a new one if none is
ongoing). After saving the data changes the user should still commit the
current transaction for the changes to be commited to the database. This
feature is also useful in general when auto-commit is off as users may
forget to commit ongoing transactions.
Thanks and Regards :D
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Akshay Joshi | 2019-07-10 10:28:23 | [pgAdmin4][Patch]: RM 4452 Add RE-SQL tests for Languages |
| Previous Message | Yosry Muhammad | 2019-07-10 09:37:52 | Re: [GSoC] Finalized First Patch |