Re: [pgAdmin4][RM3908] backgrid navigation fix for Select2Cell and PrivilegeCell

From: Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com>
To: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
Cc: Harshal Dhumal <harshal(dot)dhumal(at)enterprisedb(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][RM3908] backgrid navigation fix for Select2Cell and PrivilegeCell
Date: 2019-01-22 09:32:15
Message-ID: CAFOhELdPrasPKUJOrME6xL2L5htHtP-024nhm6MWDqPcdu9vtA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Harshal,

The Selec2Cell and PrivilegeCell are working properly but I think we should
also consider below:

1. The Backgrid and sub-node should have accessibility including every
button, cell and control.
2. The Backgrid table header is accessible through keyboard but it should
be highlighted when it gets focus.

@Akshay, we can commit this patch but we should create the separate RM for
above fixes.

Thanks,
Khushboo

On Mon, Jan 21, 2019 at 4:40 PM Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
wrote:

> Hi Khushboo
>
> Can you please review it.
>
> On Thu, Jan 17, 2019 at 7:22 PM Harshal Dhumal <
> harshal(dot)dhumal(at)enterprisedb(dot)com> wrote:
>
>> Hi,
>> Please find attached patch to fix backgrid navigation using keyboard
>> for Select2Cell and PrivilegeCell
>>
>> --
>> *Harshal Dhumal*
>> *Sr. Software Engineer*
>>
>> EnterpriseDB India: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>
> --
> *Akshay Joshi*
>
> *Sr. Software Architect *
>
>
>
> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Khushboo Vashi 2019-01-22 10:21:03 Re: [pgAdmin4][Patch] - RM 3853 - Incorrect SQL generated for create script of domain type interval with precision. ERROR: syntax error at or near "["
Previous Message Dave Page 2019-01-22 09:31:12 Re: [pgAdmin4][RM3849] Ask to save unsaved query changes stopped working