| From: | Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com> |
|---|---|
| To: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
| Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: [pgAdmin4][Patch] - RM 3853 - Incorrect SQL generated for create script of domain type interval with precision. ERROR: syntax error at or near "[" |
| Date: | 2019-01-22 10:21:03 |
| Message-ID: | CAFOhELcmBf+D=T-3mcjc2RYJiNFjLdat6W2RVhkz=19y9uAnew@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hi Akshay,
Please find the attached updated patch.
On Mon, Jan 21, 2019 at 2:57 PM Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
wrote:
> Hi Khushboo
>
> Can you please fix the following and send the patch again
>
> - PEP8 issue
>
> Fixed
>
> - Test cases is failing with Python 3.5.
>
> I have tested with Python 3.7 and it is working fine. Please give me the
log to reproduce the issue.
>
> On Mon, Jan 21, 2019 at 2:06 PM Khushboo Vashi <
> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>
>> Hi,
>>
>> Please find the attached patch to fix the RM #3853 - Incorrect SQL
>> generated for create script of domain type interval with precision. ERROR:
>> syntax error at or near "["
>>
>> The patch includes the fix as well as the API test case to verify the
>> reverse Engineered SQL.
>>
>> Thanks,
>> Khushboo
>>
>
>
> Thanks,
Khushboo
> --
> *Akshay Joshi*
>
> *Sr. Software Architect *
>
>
>
> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>
| Attachment | Content-Type | Size |
|---|---|---|
| RM_3853_v1.patch | application/octet-stream | 9.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Akshay Joshi | 2019-01-22 10:35:10 | pgAdmin 4 commit: Drop-down should be closed when click on any other to |
| Previous Message | Khushboo Vashi | 2019-01-22 09:32:15 | Re: [pgAdmin4][RM3908] backgrid navigation fix for Select2Cell and PrivilegeCell |