Re: [pgAdmin4][Patch] - RM 3853 - Incorrect SQL generated for create script of domain type interval with precision. ERROR: syntax error at or near "["

From: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
To: Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][Patch] - RM 3853 - Incorrect SQL generated for create script of domain type interval with precision. ERROR: syntax error at or near "["
Date: 2019-01-21 09:27:13
Message-ID: CANxoLDcxvRCXg_eDiaRBc+b_kT7nyJBFJFvdELm+3B5qgiRixQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Khushboo

Can you please fix the following and send the patch again

- PEP8 issue
- Test cases is failing with Python 3.5.

On Mon, Jan 21, 2019 at 2:06 PM Khushboo Vashi <
khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:

> Hi,
>
> Please find the attached patch to fix the RM #3853 - Incorrect SQL
> generated for create script of domain type interval with precision. ERROR:
> syntax error at or near "["
>
> The patch includes the fix as well as the API test case to verify the
> reverse Engineered SQL.
>
> Thanks,
> Khushboo
>

--
*Akshay Joshi*

*Sr. Software Architect *

*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Khushboo Vashi 2019-01-21 09:43:22 [pgAdmin4][Patch] - RM 3800 - User can not add database with special characters under DB restriction for add server
Previous Message Khushboo Vashi 2019-01-21 09:13:55 [pgAdmin4][Patch] - RM 3811 - Backup / restore job launch button needs two click