Re: [pgAdmin4][RM3908] backgrid navigation fix for Select2Cell and PrivilegeCell

From: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
To: Harshal Dhumal <harshal(dot)dhumal(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][RM3908] backgrid navigation fix for Select2Cell and PrivilegeCell
Date: 2019-01-22 11:07:51
Message-ID: CANxoLDdfV_=U_P4DBuCaPTseAPnz1HEZDhfac5P=xmcR5tKE6g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks patch applied

On Tue, Jan 22, 2019 at 3:02 PM Khushboo Vashi <
khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:

> Hi Harshal,
>
> The Selec2Cell and PrivilegeCell are working properly but I think we
> should also consider below:
>
> 1. The Backgrid and sub-node should have accessibility including every
> button, cell and control.
> 2. The Backgrid table header is accessible through keyboard but it should
> be highlighted when it gets focus.
>
> @Akshay, we can commit this patch but we should create the separate RM for
> above fixes.
>

RM # 3919 has been created by Harshal.

>
> Thanks,
> Khushboo
>
>
> On Mon, Jan 21, 2019 at 4:40 PM Akshay Joshi <
> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>
>> Hi Khushboo
>>
>> Can you please review it.
>>
>> On Thu, Jan 17, 2019 at 7:22 PM Harshal Dhumal <
>> harshal(dot)dhumal(at)enterprisedb(dot)com> wrote:
>>
>>> Hi,
>>> Please find attached patch to fix backgrid navigation using keyboard
>>> for Select2Cell and PrivilegeCell
>>>
>>> --
>>> *Harshal Dhumal*
>>> *Sr. Software Engineer*
>>>
>>> EnterpriseDB India: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>
>>
>> --
>> *Akshay Joshi*
>>
>> *Sr. Software Architect *
>>
>>
>>
>> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>>
>

--
*Akshay Joshi*

*Sr. Software Architect *

*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Aditya Toshniwal 2019-01-22 11:35:21 Re: [pgAdmin4][Patch] - RM 3664 - Statistic panel hangs when 1000+ tables
Previous Message Akshay Joshi 2019-01-22 11:06:06 pgAdmin 4 commit: Fixed keyboard navigation for Select2 and Privilege c