Re: Support reset of Shared objects statistics in "pg_stat_reset" function

From: Sadhuprasad Patro <b(dot)sadhu(at)gmail(dot)com>
To: Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>
Cc: Mahendra Singh Thalor <mahi6run(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Himanshu Upadhyaya <upadhyaya(dot)himanshu(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Support reset of Shared objects statistics in "pg_stat_reset" function
Date: 2021-08-22 17:23:47
Message-ID: CAFF0-CGt3e-aYppbMwz7uTXfj8tV0HFOqVony6iMx82JCWS+Sg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 2021/08/20 11:07, Mahendra Singh Thalor wrote:
> > 1)
> > Resets statistics for a single table or index in the current database
> > - to zero.
> > + to zero. The input can be a shared table also
> >
> > I think, above comment should be modified. Maybe, we can modify it as "If input is a shared oid(table or index or toast), then resets statistics for a single shared entry to zero.
>
> I'm not sure if ordinary users can understand what "shared oid" means. Instead,
> what about "Resets statistics for a single relation in the current database or
> shared across all databases in the cluster to zero."?
>

Thank you for the review here. As per the comments, attached the
latest patch here...

Thanks & Regards
SadhuPrasad
EnterpriseDB: http://www.enterprisedb.com

Attachment Content-Type Size
v5-0001-Enhancing-pg_stat_reset_single_table_counters-to-.patch application/octet-stream 2.3 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2021-08-22 17:38:39 Re: proposal: enhancing plpgsql debug API - returns text value of variable content
Previous Message Sadhuprasad Patro 2021-08-22 17:21:48 Re: Support reset of Shared objects statistics in "pg_stat_reset" function