| From: | Sadhuprasad Patro <b(dot)sadhu(at)gmail(dot)com> |
|---|---|
| To: | Mahendra Singh Thalor <mahi6run(at)gmail(dot)com> |
| Cc: | Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Himanshu Upadhyaya <upadhyaya(dot)himanshu(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Support reset of Shared objects statistics in "pg_stat_reset" function |
| Date: | 2021-08-22 17:21:48 |
| Message-ID: | CAFF0-CHSFD4=E4UvDEQeh-JwNj_aQ4XRuaD2gUKcV5b+qshY+A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> 3)
> - dbentry = pgstat_get_db_entry(msg->m_databaseid, false);
> + if (!IsSharedRelation(msg->m_objectid))
> + dbentry = pgstat_get_db_entry(msg->m_databaseid, false);
> + else
> + dbentry = pgstat_get_db_entry(InvalidOid, false);
>
> We should add some comments before this change.
In my opinion, the comments added above the function
"pgstat_recv_resetsinglecounter" and the function call
"IsSharedRelation" added are self explanatory. If we add anything
more, it will be a duplication.
So No need to add any more comments here.
Thanks & Regards
SadhuPrasad
EnterpriseDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Sadhuprasad Patro | 2021-08-22 17:23:47 | Re: Support reset of Shared objects statistics in "pg_stat_reset" function |
| Previous Message | 蔡梦娟 (玊于) | 2021-08-22 17:08:32 | Queries that should be canceled will get stuck on secure_write function |