From: | Mahendra Singh Thalor <mahi6run(at)gmail(dot)com> |
---|---|
To: | Sadhuprasad Patro <b(dot)sadhu(at)gmail(dot)com> |
Cc: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Himanshu Upadhyaya <upadhyaya(dot)himanshu(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Support reset of Shared objects statistics in "pg_stat_reset" function |
Date: | 2021-08-24 04:07:40 |
Message-ID: | CAKYtNAp4Zia3buW4oHwf1JgrgGexMhwxkchj4+xbS-pSfnDNxQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Sun, 22 Aug 2021 at 22:53, Sadhuprasad Patro <b(dot)sadhu(at)gmail(dot)com> wrote:
>
> > On 2021/08/20 11:07, Mahendra Singh Thalor wrote:
> > > 1)
> > > Resets statistics for a single table or index in the
current database
> > > - to zero.
> > > + to zero. The input can be a shared table also
> > >
> > > I think, above comment should be modified. Maybe, we can modify it as
"If input is a shared oid(table or index or toast), then resets statistics
for a single shared entry to zero.
> >
> > I'm not sure if ordinary users can understand what "shared oid" means.
Instead,
> > what about "Resets statistics for a single relation in the current
database or
> > shared across all databases in the cluster to zero."?
> >
>
> Thank you for the review here. As per the comments, attached the
> latest patch here...
>
Thanks Sadhu for the updated patch.
Patch looks good to me and I don't have any more comments.
I marked this patch as 'ready for committer'.
https://commitfest.postgresql.org/34/3282/
--
Thanks and Regards
Mahendra Singh Thalor
EnterpriseDB: http://www.enterprisedb.com
From | Date | Subject | |
---|---|---|---|
Next Message | Greg Nancarrow | 2021-08-24 04:20:19 | Re: Parallel scan with SubTransGetTopmostTransaction assert coredump |
Previous Message | Amit Langote | 2021-08-24 03:03:59 | Re: Allow batched insert during cross-partition updates |