| From: | John Naylor <john(dot)naylor(at)enterprisedb(dot)com> |
|---|---|
| To: | David Rowley <dgrowleyml(at)gmail(dot)com> |
| Cc: | John Naylor <john(dot)naylor(at)postgresql(dot)org>, pgsql-committers(at)lists(dot)postgresql(dot)org, Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Subject: | Re: pgsql: Specialize tuplesort routines for different kinds of abbreviated |
| Date: | 2022-05-11 08:42:05 |
| Message-ID: | CAFBsxsFmt4_JUP8XgSJqwaAS9a9s8K8_PvMu=j=DfwU=8QjNPw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On Wed, May 11, 2022 at 6:43 AM David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
>
> I pushed this after I made a small adjustment to #ifdef out the
> qsort_tuple_signed sort specialization in 32-bit builds. On testing a
> 32-bit build with the patch I proposed, I was getting a warning about
> that function being unused.
Earlier I looked at your patch, but didn't think to check the rest of
the code affected by this commit. Do we also need something like the
attached, for the ApplyXYZSortComparator functions? (I don't have a
32-bit platform to test on)
--
John Naylor
EDB: http://www.enterprisedb.com
| Attachment | Content-Type | Size |
|---|---|---|
| further-datum-cleanups.patch | text/x-patch | 1.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2022-05-11 10:21:07 | Re: pgsql: Specialize tuplesort routines for different kinds of abbreviated |
| Previous Message | Michael Paquier | 2022-05-11 06:39:57 | pgsql: Fix typos and grammar in code and test comments |