Re: pgsql: Specialize tuplesort routines for different kinds of abbreviated

From: David Rowley <dgrowleyml(at)gmail(dot)com>
To: John Naylor <john(dot)naylor(at)enterprisedb(dot)com>
Cc: John Naylor <john(dot)naylor(at)postgresql(dot)org>, pgsql-committers(at)lists(dot)postgresql(dot)org, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
Subject: Re: pgsql: Specialize tuplesort routines for different kinds of abbreviated
Date: 2022-05-11 10:21:07
Message-ID: CAApHDvqAsMXppxrio=qMGXk74b3K9rUsw+4+bT_7YN9-tsp-FA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Wed, 11 May 2022 at 20:42, John Naylor <john(dot)naylor(at)enterprisedb(dot)com> wrote:
> Earlier I looked at your patch, but didn't think to check the rest of
> the code affected by this commit. Do we also need something like the
> attached, for the ApplyXYZSortComparator functions? (I don't have a
> 32-bit platform to test on)

I didn't notice those.

I'm pretty sure those macros need to be used any time we want to
convert a Datum into a C type.

David

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2022-05-11 10:41:42 Re: pgsql: Specialize tuplesort routines for different kinds of abbreviated
Previous Message John Naylor 2022-05-11 08:42:05 Re: pgsql: Specialize tuplesort routines for different kinds of abbreviated