Re: pgsql: Specialize tuplesort routines for different kinds of abbreviated

From: David Rowley <dgrowleyml(at)gmail(dot)com>
To: John Naylor <john(dot)naylor(at)enterprisedb(dot)com>
Cc: John Naylor <john(dot)naylor(at)postgresql(dot)org>, pgsql-committers(at)lists(dot)postgresql(dot)org, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
Subject: Re: pgsql: Specialize tuplesort routines for different kinds of abbreviated
Date: 2022-05-10 23:43:15
Message-ID: CAApHDvrtmqW_m9UMf37Fk_qgX6Voy_AX6-YVzj=-=HZJk-1tpg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Tue, 10 May 2022 at 21:45, John Naylor <john(dot)naylor(at)enterprisedb(dot)com> wrote:
>
> On Tue, May 10, 2022 at 3:46 PM David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
> > What do you think?
>
> +1

Thanks for having a look.

I pushed this after I made a small adjustment to #ifdef out the
qsort_tuple_signed sort specialization in 32-bit builds. On testing a
32-bit build with the patch I proposed, I was getting a warning about
that function being unused.

I found the 32-bit postgres binary is now an entire 4376 bytes smaller!

David

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2022-05-11 01:24:16 pgsql: Improve setup of environment values for commands in MSVC's vcreg
Previous Message David Rowley 2022-05-10 23:40:04 pgsql: Fix some incorrect preprocessor tests in tuplesort specializatio