Detach partition with constraint test

From: Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>
To: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, amul sul <sulamul(at)gmail(dot)com>, Peter Eisentraut <peter(at)eisentraut(dot)org>
Subject: Detach partition with constraint test
Date: 2025-04-03 12:22:24
Message-ID: CAExHW5vjmT5EC-hdnpzCph261pM2PWbUxfd9=C9du6LKayMe1g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,
I tested the "not enforced" constraint feature extensively today
especially the cases of partitioned table. Everything seems to be
working fine.

While doing that, I found that foreign_key.sql does not have a test to
make sure that a partition continues to have the constraints in the
same state after detaching. Here's a 0001 patch adding those tests in
the same block as the not enforced constraints. Probably we could add
similar test in other blocks as well, but I haven't done that yet.
Checking if something like this would be acceptable.

0002 fixes a comment in the same block.

--
Best Wishes,
Ashutosh Bapat

Attachment Content-Type Size
0001-Test-detaching-a-partition-with-foreign-key-20250403.patch text/x-patch 4.1 KB
0002-Fix-an-inaccurate-comment-20250403.patch text/x-patch 2.1 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Hayato Kuroda (Fujitsu) 2025-04-03 12:23:58 RE: Some codes refer slot()->{'slot_name'} but it is not defined
Previous Message Tomas Vondra 2025-04-03 12:15:12 Re: Draft for basic NUMA observability