From: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
---|---|
To: | 'Fujii Masao' <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, "'pgsql-hackers(at)lists(dot)postgresql(dot)org'" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | RE: Some codes refer slot()->{'slot_name'} but it is not defined |
Date: | 2025-04-03 12:23:58 |
Message-ID: | OSCPR01MB149665DBB57C5C835143E75DCF5AE2@OSCPR01MB14966.jpnprd01.prod.outlook.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Dear Fujii-san,
> -is($node_primary->slot('dropme_slot')->{'slot_name'},
> - undef, 'logical slot was actually dropped on standby');
> +is($node_primary->slot('dropme_slot')->{'plugin'},
> + '', 'logical slot was actually dropped on standby');
>
> This seems like a separate issue from what your patch is addressing,
> but since this test is meant to confirm that the slot was dropped
> on the standby, shouldn't node_primary be node_replica instead?
You are right. It has been missed 8 years ago, let's fix now.
BTW, the issue exists for all supported branches. How do you feel
to backpatch them? PSA all patch set.
Best regards,
Hayato Kuroda
FUJITSU LIMITED
Attachment | Content-Type | Size |
---|---|---|
v2-PG13-0001-Fix-invalid-referring-of-hash-ref-for-replic.patch | application/octet-stream | 2.4 KB |
v2-PG16-PG14-0001-Fix-invalid-referring-of-hash-ref-for-replic.patch | application/octet-stream | 2.4 KB |
v2-master-PG17-0001-Fix-invalid-referring-of-hash-ref-for-replic.patch | application/octet-stream | 2.4 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Jakub Wartak | 2025-04-03 12:36:57 | Re: Draft for basic NUMA observability |
Previous Message | Ashutosh Bapat | 2025-04-03 12:22:24 | Detach partition with constraint test |