| From: | Amul Sul <sulamul(at)gmail(dot)com> |
|---|---|
| To: | Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Peter Eisentraut <peter(at)eisentraut(dot)org> |
| Subject: | Re: Detach partition with constraint test |
| Date: | 2025-04-04 04:01:01 |
| Message-ID: | CAAJ_b9657KoLOUjy_vd-oJE+FA_mSkm_nAoTOjReGV+nGj-Gag@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Apr 3, 2025 at 5:52 PM Ashutosh Bapat
<ashutosh(dot)bapat(dot)oss(at)gmail(dot)com> wrote:
>
> Hi,
> I tested the "not enforced" constraint feature extensively today
> especially the cases of partitioned table. Everything seems to be
> working fine.
>
> While doing that, I found that foreign_key.sql does not have a test to
> make sure that a partition continues to have the constraints in the
> same state after detaching. Here's a 0001 patch adding those tests in
> the same block as the not enforced constraints. Probably we could add
> similar test in other blocks as well, but I haven't done that yet.
> Checking if something like this would be acceptable.
>
> 0002 fixes a comment in the same block.
>
Thanks for the testing; both patches look quite reasonable to me.
Regards,
Amul
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2025-04-04 04:06:43 | Re: Improve error reporting for few options in pg_createsubscriber |
| Previous Message | Hayato Kuroda (Fujitsu) | 2025-04-04 03:28:27 | RE: pg_recvlogical cannot create slots with failover=true |