Re: list_free in addRangeTableEntryForJoin

From: Ranier Vilela <ranier(dot)vf(at)gmail(dot)com>
To: Ilia Evdokimov <ilya(dot)evdokimov(at)tantorlabs(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: list_free in addRangeTableEntryForJoin
Date: 2024-06-10 12:18:54
Message-ID: CAEudQApdbWD2vwXG1hZUwGbOd6TLp3eHi48LRYhjsE6Fzv0Tnw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Em seg., 10 de jun. de 2024 às 09:11, Ilia Evdokimov <
ilya(dot)evdokimov(at)tantorlabs(dot)com> escreveu:

> >But callers of addRangeTableEntryForJoin(), expects to handle a list
> or NIL, if we free the memory
> I've thoroughly reviewed all callers of the
> `addRangeTableEntryForJoin()` function and confirmed that the list is
> not used after this function is called. Since
> `addRangeTableEntryForJoin()` is the last function to use this list, it
> would be more efficient to free the `List` at the point of its declaration.
>
> I'll attach new patch where I free the lists.
>
Seems like a better style.

Now you need to analyze whether the memory in question is not managed by a
Context and released in a block,
which would make this release useless.

best regards,
Ranier Vilela

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message James Coleman 2024-06-10 12:28:28 Re: Fix grammar oddities in comments
Previous Message Ilia Evdokimov 2024-06-10 12:11:27 Re: list_free in addRangeTableEntryForJoin