From: | James Coleman <jtc331(at)gmail(dot)com> |
---|---|
To: | David Rowley <dgrowleyml(at)gmail(dot)com> |
Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Fix grammar oddities in comments |
Date: | 2024-06-10 12:28:28 |
Message-ID: | CAAaqYe_aoH0yDJdXY+K45f6s+cqM0bACKYhWHdReGFu243HjvQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, Jun 5, 2024 at 5:34 AM David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
>
> On Sun, 2 Jun 2024 at 10:08, James Coleman <jtc331(at)gmail(dot)com> wrote:
> > See attached for a small patch fixing some typos and grammatical
> > errors in a couple of comments.
>
> Thanks. I pushed this after messing with the comments a bit more.
Thanks!
> > Side note: It's not clear to me what "Vars of higher levels don't
> > matter here" means in this context (or how that claim is justified),
> > but I haven't changed that part of the comment opting to simply
> > resolve the clear mistakes in the wording here.
>
> It just means Vars with varlevelsup >= 2 don't matter. It only cares
> about Vars with varlevelsup==1, i.e. Vars of the sub-query's direct
> parent.
Yes, I understood the content, but I didn't see any justification
provided, which is what I'd hope for in a comment like this (why not
simply what).
Anyway, thanks again for reviewing and committing.
James Coleman
From | Date | Subject | |
---|---|---|---|
Next Message | Shlok Kyal | 2024-06-10 12:29:12 | Re: confirmed flush lsn seems to be move backward in certain error cases |
Previous Message | Ranier Vilela | 2024-06-10 12:18:54 | Re: list_free in addRangeTableEntryForJoin |