Re: Fix grammar oddities in comments

From: David Rowley <dgrowleyml(at)gmail(dot)com>
To: James Coleman <jtc331(at)gmail(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Fix grammar oddities in comments
Date: 2024-06-05 09:34:43
Message-ID: CAApHDvpKdiEHcGs_jX2dijsx-N8eWhDoyU7BqHFoYT=p3au-MA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, 2 Jun 2024 at 10:08, James Coleman <jtc331(at)gmail(dot)com> wrote:
> See attached for a small patch fixing some typos and grammatical
> errors in a couple of comments.

Thanks. I pushed this after messing with the comments a bit more.

> Side note: It's not clear to me what "Vars of higher levels don't
> matter here" means in this context (or how that claim is justified),
> but I haven't changed that part of the comment opting to simply
> resolve the clear mistakes in the wording here.

It just means Vars with varlevelsup >= 2 don't matter. It only cares
about Vars with varlevelsup==1, i.e. Vars of the sub-query's direct
parent.

David

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Richard Guo 2024-06-05 09:42:42 Re: Wrong results with grouping sets
Previous Message Dave Page 2024-06-05 09:30:54 Re: meson "experimental"?