Re: Missing const in DSA.

From: Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: markg735(at)gmail(dot)com, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Missing const in DSA.
Date: 2018-09-24 00:27:13
Message-ID: CAEepm=1urhudvr-6RVb8KCa8-cUC0gRj6OP81q8tGOJ_J3ac0g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Sep 24, 2018 at 9:32 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Mark G <markg735(at)gmail(dot)com> writes:
> > While looking at some of the recent churn in DSA I noticed that
> > dsa_size_class_map should probably be declared const.
>
> +1 ... also, given the contents of the array, "char" seems like
> rather a misnomer. I'd be happier if it were declared as uint8, say.

+1

--
Thomas Munro
http://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Haribabu Kommi 2018-09-24 01:08:14 Revoke execution permission of pg_stat_statements_reset() from pg_read_all_stats role
Previous Message Andrew Gierth 2018-09-24 00:26:44 Re: Add RESPECT/IGNORE NULLS and FROM FIRST/LAST options