Re: Missing const in DSA.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Mark G <markg735(at)gmail(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Missing const in DSA.
Date: 2018-09-23 21:32:17
Message-ID: 3632.1537738337@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Mark G <markg735(at)gmail(dot)com> writes:
> While looking at some of the recent churn in DSA I noticed that
> dsa_size_class_map should probably be declared const.

+1 ... also, given the contents of the array, "char" seems like
rather a misnomer. I'd be happier if it were declared as uint8, say.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Munro 2018-09-23 21:48:13 Re: Collation versioning
Previous Message Tom Lane 2018-09-23 21:13:52 Re: Add RESPECT/IGNORE NULLS and FROM FIRST/LAST options