| From: | Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com> |
|---|---|
| To: | pgsql-hackers(at)lists(dot)postgresql(dot)org, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Dave Page <dpage(at)pgadmin(dot)org>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
| Subject: | Revoke execution permission of pg_stat_statements_reset() from pg_read_all_stats role |
| Date: | 2018-09-24 01:08:14 |
| Message-ID: | CAJrrPGf5fCnKqXObpwGN9nMyD--tzOf-7LFCJiz59Z1wJ5qj9A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
[spawning a new thread]
In commit 25fff40798 the execute permission of pg_stat_statements_reset()
is provided to pg_read_all_stats role in [1].
The execute permissions grant to pg_read_all_stats concern is raised in [2]
during the discussion of supporting different methods of reset the stats,
instead of resetting all.
Here I attached the patch that reverts the permission grant as per the
discussion
in [3].
[1] -
https://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=25fff40798fc4ac11a241bfd9ab0c45c085e2212#patch8
[2] -
https://www.postgresql.org/message-id/CAHGQGwE8Roydg-bVweK8GjpOipWh3rAAstMqoUfz7qBFrs8Tuw%40mail.gmail.com
[3] -
https://www.postgresql.org/message-id/CAJrrPGdre9CqaHsbgtsc3LmJSRFg41fOZ%2BZVpX9zu3D1fGqAeQ%40mail.gmail.com
Regards,
Haribabu Kommi
Fujitsu Australia
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Revoke-pg_stat_statements_reset-permissions_v2.patch | application/octet-stream | 2.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Haribabu Kommi | 2018-09-24 01:13:43 | Re: New function pg_stat_statements_reset_query() to reset statistics of a specific query |
| Previous Message | Thomas Munro | 2018-09-24 00:27:13 | Re: Missing const in DSA. |