| From: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Jesper Pedersen <jesper(dot)pedersen(at)redhat(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, Oskari Saarenmaa <os(at)ohmu(dot)fi>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Tobias Oberstein <tobias(dot)oberstein(at)gmail(dot)com> |
| Subject: | Re: pread() and pwrite() |
| Date: | 2018-10-09 20:56:35 |
| Message-ID: | CAEepm=1X9htKVEXbPZnH8ebF+Mo5kVkTZq3pg9gmdu=1Xx8rnA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Oct 9, 2018 at 5:08 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> I wrote:
> > Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> writes:
> >> On Tue, Oct 9, 2018 at 2:55 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> >>> Yeah, I've been burnt by that too recently. It occurs to me we could make
> >>> that at least a little less painful if we formatted the macro with one
> >>> line per function name:
>
> >> +1, was about to suggest the same!
>
> > Sold, I'll go do it.
>
> Learned a few new things about M4 along the way :-( ... but done.
> You'll need to rebase the pread patch again of course.
Thanks, much nicer. Rebased.
--
Thomas Munro
http://www.enterprisedb.com
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Use-pread-pwrite-instead-of-lseek-read-write-v7.patch | application/octet-stream | 25.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Fetter | 2018-10-09 21:08:53 | Re: [HACKERS] removing abstime, reltime, tinterval.c, spi/timetravel |
| Previous Message | Andres Freund | 2018-10-09 20:43:48 | Re: [HACKERS] removing abstime, reltime, tinterval.c, spi/timetravel |