Re: pread() and pwrite()

From: Jesper Pedersen <jesper(dot)pedersen(at)redhat(dot)com>
To: Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Magnus Hagander <magnus(at)hagander(dot)net>, Oskari Saarenmaa <os(at)ohmu(dot)fi>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Tobias Oberstein <tobias(dot)oberstein(at)gmail(dot)com>
Subject: Re: pread() and pwrite()
Date: 2018-11-02 13:07:25
Message-ID: 4cf40b3d-96ed-7597-fb42-e5e29c5a40fe@redhat.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Thomas,

On 10/9/18 4:56 PM, Thomas Munro wrote:
> Thanks, much nicer. Rebased.
>

This still applies, and passes make check-world.

I wonder what the commit policy is on this, if the Windows part isn't
included. I read Heikki's comment [1] as it would be ok to commit
benefiting all platforms that has pread/pwrite.

The functions in [2] could be a follow-up patch as well.

[1]
https://www.postgresql.org/message-id/6cc7c8dd-29f9-7d75-d18a-99f19c076d10%40iki.fi
[2]
https://www.postgresql.org/message-id/c2f56d0a-cadd-3df1-ae48-b84dc8128c37%40redhat.com

Best regards,
Jesper

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message LAM JUN RONG 2018-11-02 13:07:50 [PATCH] Improvements to "Getting started" tutorial for Google Code-in task
Previous Message Etsuro Fujita 2018-11-02 13:05:36 Re: BUG #15449: file_fdw using program cause exit code error when using LIMIT