| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> |
| Cc: | Jesper Pedersen <jesper(dot)pedersen(at)redhat(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, Oskari Saarenmaa <os(at)ohmu(dot)fi>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Tobias Oberstein <tobias(dot)oberstein(at)gmail(dot)com> |
| Subject: | Re: pread() and pwrite() |
| Date: | 2018-10-09 04:08:33 |
| Message-ID: | 2145.1539058113@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
I wrote:
> Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> writes:
>> On Tue, Oct 9, 2018 at 2:55 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>> Yeah, I've been burnt by that too recently. It occurs to me we could make
>>> that at least a little less painful if we formatted the macro with one
>>> line per function name:
>> +1, was about to suggest the same!
> Sold, I'll go do it.
Learned a few new things about M4 along the way :-( ... but done.
You'll need to rebase the pread patch again of course.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2018-10-09 05:38:35 | Re: [HACKERS] Optional message to user when terminating/cancelling backend |
| Previous Message | Yang Xiao | 2018-10-09 03:43:44 | [ECPG] fix functions in dt_common to correctly detect integer overflow |